Skip to content

Properly compare positions for cache validation #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

Properly compare positions for cache validation #2712

merged 1 commit into from
Jan 10, 2025

Conversation

AndreasArvidsson
Copy link
Member

You can't compare position instances with ===

Checklist

  • [/] I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner January 9, 2025 21:37
@phillco phillco added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit f9a9ec1 Jan 10, 2025
15 checks passed
@phillco phillco deleted the cachePositionEqual branch January 10, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phillco phillco phillco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndreasArvidsson @phillco